How to add valueset?
# support
b
For Practitioner Qualification Code, I want to use the values in http://hl7.org/fhir/ValueSet/provider-qualification. I'm open to using other/similar Valuesets for this resource (Practitioner). I've looked for documenation and tried various things in local medplum app (http://localhost:3002/ValueSet?_count=20&_fields=id,_lastUpdated,name,title,status&_offset=0&_sort=-_lastUpdated). I've also rebuilt my Value Sets in super admin (http://localhost:3002/admin/super), but I am not getting Practitioner Qualification codes in the form (http://localhost:3002/Practitioner/new). What is the correct way to add Qualification valueset for Practitioners? I'm not sure if editing these files is the intended way (packages/definitions/dist/fhir/r4/valuesets.json, packages/definitions/dist/fhir/r4/dataelements.json, packages/definitions/dist/fhir/r4/profiles-resources.json) to set the Valueset on a Resource. Thanks
@rahul1 I found a bug https://github.com/medplum/medplum/issues/3563 with the codesystem & valueset and created a PR fix using the latest from hl7.org https://github.com/medplum/medplum/pull/3564
r
Hi @bubbly_puppy_96894 , good find! Thank you for the contribution. So it turns out that is not a bug per se , but definitely confusing behavior. The official FHIR spec actually specifies v2-2.7-0360 as the terminology for this element, with a binding strength of "example". https://hl7.org/fhir/R4/practitioner.html
However, this valueset is not what is shipped with the base specification, whcih makes it less useful
I think the change in this PR seems reasonable, and we'll have the eng team review and sign off
Thanks again for taking the time to contribute
b
@rahul1 thanks for the update. the problem is that URL https://terminology.hl7.org/ValueSet/v2-2.7-0360 is 404. is that an hl7.org issue?
In the issue, I mention how medplum's $expand fails with the 2.7-0360 url https://github.com/medplum/medplum/issues/3563
r
Good question @bubbly_puppy_96894 . Before updating the data definitions, I'm trying to do a pass of due diligence. Those definitions come straight from FHIR, so I just want to make sure there isn't a bug in our
expand
logic before updating the core resouces
b
yeah, I understand.
v2-2.7-0360
seems good but the medplum server has to be able to $expand the ValueSet. currently getting
400 (Bad Request)
r
Hi @bubbly_puppy_96894 , I looked into this and it turns out we weren't ingesting those v2 tables at all. I think the right solution would be to make sure our server is building those during startup. Would it be ok if I opened up another PR to try that ingestion?
b
sounds good. @rahul1 I think everyone could use working
Practitioner.qualification.code
r
Totally Agree. Still working on this and hoping to give you an udpate soon
Hi Rex, we have fixed this in a different PR (https://github.com/medplum/medplum/pull/3595) The root issue was that we were not ingesting some of the code systems from HL7v2 . The Medplum service now ingests those on startup, and they should show up in the typehead
b
Thanks @rahul1 !
149 Views